This repository was archived by the owner on Jan 6, 2025. It is now read-only.
Add missing error handling #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs rebase now that #20 was merged. |
johncantrell97
force-pushed
the
error-handling
branch
from
67f1b97 to
b080f59
Compare
|
Needs a rebase now that #22 landed. |
johncantrell97
force-pushed
the
error-handling
branch
from
b080f59 to
5210d59
Compare
|
rebased |
tnull
approved these changes
Nov 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are missing a lot of the actual error codes/responses that the specification specifies. This PR attempts to add support for the missing ones.
At the moment it's just the two get_info errors.